Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v.generalize: Fix Resource Leak issue in displacement.c #4422

Merged
merged 2 commits into from
Oct 1, 2024
Merged

v.generalize: Fix Resource Leak issue in displacement.c #4422

merged 2 commits into from
Oct 1, 2024

Conversation

ShubhamDesai
Copy link
Contributor

This pull request addresses resource leak issue identified by coverity scan (CID : 1207602)
Used existing function Vect_destroy_cats_struct() to fix the memory leak issue.

nilason
nilason requested changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@nilason nilason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you’re at it, you can destroy Points too.

@github-actions github-actions bot added vector Related to vector data processing C Related code is in C module labels Sep 30, 2024
@ShubhamDesai
Copy link
Contributor Author

While you’re at it, you can destroy Points too.

Done

nilason
nilason approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@nilason nilason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@echoix echoix merged commit 6382949 into OSGeo:main Oct 1, 2024
26 checks passed
@nilason nilason added this to the 8.5.0 milestone Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilason nilason nilason approved these changes

Assignees
No one assigned
Labels
C Related code is in C module vector Related to vector data processing
Projects
GRASS GIS Security
Status: No status
Milestone
8.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ShubhamDesai @nilason @echoix